Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action View Docs: field_id and field_name examples [ci skip] #50245

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

seanpdoyle
Copy link
Contributor

@seanpdoyle seanpdoyle commented Dec 2, 2023

Motivation / Background

Several code samples for field_id and field_name cite the use of text_field_tag-style helper. That usage is incorrect. The helper interface that field_id and field_name mimic is the text_field-style helper, without the _tag suffix.

Several code samples for `field_id` and `field_name` cite the use of
[text_field_tag][]-style helper. That usage is incorrect. The helper
interface that `field_id` and `field_name` mimic is the
[text_field][]-style helper, without the `_tag` suffix.

[text_field_tag]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/FormTagHelper.html#method-i-text_field_tag
[text_field]: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-text_field
@rails-bot rails-bot bot added the actionview label Dec 2, 2023
@p8 p8 merged commit 6908a66 into rails:main Dec 2, 2023
@p8
Copy link
Member

p8 commented Dec 2, 2023

Thanks @seanpdoyle !

@seanpdoyle seanpdoyle deleted the field-id-field-name-docs branch December 2, 2023 17:50
p8 added a commit to p8/rails that referenced this pull request Dec 3, 2023
Action View Docs: `field_id` and `field_name` examples [ci skip]
p8 added a commit that referenced this pull request Dec 3, 2023
…50250)

Action View Docs: `field_id` and `field_name` examples [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants