Use Rack::QueryParser with nil missing value.
#47652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
rack-3-query-parser
branch
from
2e57380 to
1159039
Compare
|
I've released rack v3.0.6 with rack/rack#2052 which should be sufficient to make this PR pass. |
Rack 3 follows the WhatWG standard for the query parser. This deviates from
Rack 2 as `?a` as a query string is was previously interpreted as
`{"a" => nil}` but is now interpreted as `{"a" => ""}`. Rails depends on
the previous behaviour for compatibility, so we introduced hooks into Rack
to restore compatibility.
ioquatix
force-pushed
the
rack-3-query-parser
branch
from
1159039 to
f336b47
Compare
This was referenced Mar 13, 2023
|
@matthewd this seems to fix the tests + the rack keyed cache PR... |
|
This will only work once rack/rack#2054 is merged and back ported to |
|
We have decided to revert this behaviour in Rack. Thus this PR is no longer necessary. The backport was released in Rack v3.0.7. |
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
May 15, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
May 15, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
May 16, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Aug 7, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
geoffharcourt
pushed a commit
to commonlit/sinatra
that referenced
this pull request
Nov 6, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Dec 23, 2023
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Jan 2, 2024
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Jan 5, 2024
Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack 3 follows the WhatWG standard for the query parser. This deviates from
Rack 2 as
?aas a query string is was previously interpreted as{"a" => nil}but is now interpreted as{"a" => ""}. Rails depends onthe previous behaviour for compatibility, so we introduced hooks into Rack
to restore compatibility.
This depends on rack/rack#2052 being merged and released as part of Rack 3.0.
cc @matthewd @tenderlove