Validate ActiveStorage::Blob io is rewindable #46548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Earlopain
changed the title
ActiveStorage::Blob.create_and_upload!(io: file_fixture("test.jpg"), filename: "dummy")
The code looks reasonable, but actually results in an infinite loop
before this change. Now an error is propagated to the user instead.
Closes #46507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Makes
ActiveStorage::Blob.create_and_upload!raise on non-rewindable io. See #46507Both versions look reasonable, but only one works. Without the read call after file_fixture calculating the checksum loops infinitely. This will now propagate an error to the user instead.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]