-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow upgrade to rack 3.0 #45741
Allow upgrade to rack 3.0 #45741
Conversation
It's a bit complicated to add another gem version to the "matrix", we test multiple Ruby versions, but not multiple dependency versions. I'd encourage you to first open a PR that points to rack 3 to see if we can spot some compatibility problems, and if so we'll address them. |
Note to self: CI is failing because |
Do you mind explaining how to do this, because I tried to find a BK pipeline config but couldn't find it. I could not see how to achieve what you are describing, unless you mean add |
Yeah I think that's what he meant
While complicated, I do think if the plan is to support both versions in the next release we probably want both tested. Maybe running an https://github.com/rails/buildkite-config Buildkite config is here |
I have created a branch/PR to resolve the issue with sprockets preventing rack 3 at rails/sprockets#758 - but there appears to be some similar issues with some other test dependencies.
|
An alternative to moving rails-ujs out of the repo would be #45546, which could be followed up by removing Blade |
Please see #46594 for an updated attempt. |
Should we add Rack 3 to the text matrix? It's not released yet but will be soon, in the mean time you can get it from
git: "https://github.com/rack/rack"
.