Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lower case normalisation for cookie attributes. #1849

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 6, 2022

Fixes #1848

@ioquatix ioquatix force-pushed the cookie-attribute-case-insensitive branch from 25003ed to 3c0a9e7 Compare April 6, 2022 07:54
@ioquatix ioquatix enabled auto-merge (squash) April 6, 2022 08:44
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to CHANGELOG, otherwise looks fine.

CHANGELOG.md Outdated Show resolved Hide resolved
@ioquatix ioquatix requested a review from jeremyevans April 6, 2022 22:19
@ioquatix ioquatix merged commit f06e49d into main Apr 7, 2022
@ioquatix ioquatix deleted the cookie-attribute-case-insensitive branch April 7, 2022 02:43
dentarg added a commit to dentarg/sinatra that referenced this pull request Dec 28, 2022
dentarg added a commit to dentarg/sinatra that referenced this pull request Dec 30, 2022
dentarg added a commit to dentarg/sinatra that referenced this pull request Feb 13, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Feb 24, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Mar 4, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Mar 5, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Apr 11, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request May 15, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request May 16, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Aug 7, 2023
geoffharcourt pushed a commit to commonlit/sinatra that referenced this pull request Nov 6, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Dec 23, 2023
dentarg added a commit to dentarg/sinatra that referenced this pull request Jan 2, 2024
dentarg added a commit to dentarg/sinatra that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie attribute names should be matched case insensitively.
2 participants