Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie attribute names should be matched case insensitively. #1848

Closed
ioquatix opened this issue Apr 6, 2022 · 1 comment · Fixed by #1849
Closed

Cookie attribute names should be matched case insensitively. #1848

ioquatix opened this issue Apr 6, 2022 · 1 comment · Fixed by #1849

Comments

@ioquatix
Copy link
Member

ioquatix commented Apr 6, 2022

After reviewing more of the cookie code, I noticed we are case sensitive on some parts, namely secure and httponly in some cases.

https://tools.ietf.org/search/rfc6265 p18-20 discuss that these fields should match case insensitively but we use case sensitive string keys in mock.rb and possibly other places.

I suggest we lower case these to normalise the fields, since it seems like this is probably what we expect 99% of the time.

@ioquatix
Copy link
Member Author

ioquatix commented Apr 6, 2022

dentarg added a commit to dentarg/sinatra that referenced this issue Dec 28, 2022
dentarg added a commit to dentarg/sinatra that referenced this issue Dec 30, 2022
dentarg added a commit to dentarg/sinatra that referenced this issue Feb 13, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Feb 24, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Mar 4, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Mar 5, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Apr 11, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue May 15, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue May 16, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Aug 7, 2023
geoffharcourt pushed a commit to commonlit/sinatra that referenced this issue Nov 6, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Dec 23, 2023
dentarg added a commit to dentarg/sinatra that referenced this issue Jan 2, 2024
dentarg added a commit to dentarg/sinatra that referenced this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants