remove tx.origin checks #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quazia
approved these changes
Mar 19, 2024
test/QuestFactory.t.sol
Outdated
| @@ -306,8 +305,7 @@ contract TestQuestFactory is Test, Errors, Events, TestUtils { | |||
| } | |||
|
|
|||
| function test_claimCompressed_revert_txOriginMismatch() public{ | |||
There was a problem hiding this comment.
Should we just remove the whole test?
There was a problem hiding this comment.
Yeah, I always feel iffy about deleting tests that assert specific behavior like this. Open to removing it.
There was a problem hiding this comment.
Well we arn't asserting that behavior anymore, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
tx.originvalidation