Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg.sender changes, not tx.origin #254

Merged
merged 3 commits into from
Jan 5, 2024
Merged

msg.sender changes, not tx.origin #254

merged 3 commits into from
Jan 5, 2024

Conversation

waynehoover
Copy link
Contributor

No description provided.

@waynehoover waynehoover requested a review from a team as a code owner January 5, 2024 18:45
Quazia
Quazia approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only concern is with the unit testing. Are we testing that it does throw txOriginMismatch when it's not the same origin/sender?

@waynehoover
Copy link
Contributor Author

@Quazia I added some tests to test for that.

@waynehoover waynehoover merged commit 236579e into main Jan 5, 2024
2 checks passed
@waynehoover waynehoover deleted the deploy_everywhere_2 branch January 5, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quazia Quazia Quazia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waynehoover @Quazia