Add compressed claim function to Quest contracts #244
Conversation
waynehoover
changed the title
|
|
||
| function getQuestId() public view virtual returns (string memory); | ||
|
|
||
| function claim() external payable { |
There was a problem hiding this comment.
How does this get handled when settled to L1 and how does the gas used work in this call?
There was a problem hiding this comment.
We can still access calldata in this function via msg.data or calldataload(offset) in assembly, both of which are done here in this function.
So as you can see in the tests we need to send a raw tx call for this to work, we can't call the function normally. We send the raw tx call prefixed with the 4 byte claim() function selector and then the rest of the bytes in the calldata can be accessed via msg.data[4:]. So from a L1 perspective it's all the same: it's a transaction with calldata.
So essentially what this does is remove the need to abi encode the calldata as a dynamic bytes array saving us two words (because encoding a bytes array adds two words when abi encoded to encode its length and data start position) ((granted they are mostly zeros but any savings is good here)).
This will bring our calldata down from 212 bytes to 116 (with a referrer) a saving of 45.28%.
claimfunction to the Quest and Quest1155 contracts via the abstract contractQuestClaimable.txHashChainIdin quest creation.