Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy to Mantle #220

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Deploy to Mantle #220

merged 7 commits into from
Oct 16, 2023

Conversation

waynehoover
Copy link
Contributor

@waynehoover waynehoover commented Oct 16, 2023 •
edited
Loading

  • broadcasts for the mantle network deploy, and upgrading the QuestFactory to the latest version
  • Change the deploy script slightly for the QuestFactory to also include deploying Quest and Quest1155
  • Update Readme

waynehoover
waynehoover commented Oct 16, 2023
View reviewed changes
contracts/QuestFactory.sol
@@ -335,11 +335,6 @@ contract QuestFactory is Initializable, LegacyStorage, OwnableRoles, IQuestFacto
SET
//////////////////////////////////////////////////////////////*/

/// @dev temporary function to set owner for solady ownable
function setOwnerOnce() external {
Copy link
Contributor Author

@waynehoover waynehoover Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore, as it has been run with the upgrade that happened on every chain in this PR. I also manually verified the owner address is set correctly on each chain.

Quazia
Quazia approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for documenting the mantle/scroll specific deployment edge cases

@waynehoover waynehoover merged commit ebb475a into main Oct 16, 2023
2 checks passed
@waynehoover waynehoover deleted the deploy_scroll_and_mantle branch October 16, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quazia Quazia Quazia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waynehoover @Quazia