feature: Infer status from provided parameters #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributes to #72 |
|
Also contributes to #70, kind of |
We'll use this to infer `inProgress` or `completed`
boswelja
force-pushed
the
feature/refactor-status
branch
from
7ef6538 to
471f070
Compare
This will be required for draft/halted It is optional though, if it's not specified, we have updated logic for inferring it
This reverts commit ad98b3d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statuscan now be correctly inferred based onuserFraction. Currently, the following rules apply when status is not supplied:if
userFractionis 1.0,statusis completedif
userFractionis 0.0,statusis haltedif
userFractionis between 0.0 and 1.0,statusis inProgressNote you can still provide
statusmanually. Doing so will subjectuserFractionto stricter rules, as above.