Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FirewallRules concurency issues using a status known LastTransiti… #124

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

vincentmrg
Copy link
Contributor

@vincentmrg vincentmrg commented Jul 1, 2024

If a rule LastTransitionTime is before the one stored locally, the cache is not yet aware of a change we made.
To avoid consistency issues, e.g. creating multiples groups for a single node, we requeue.

@vincentmrg vincentmrg force-pushed the fix/firewallrules-concurency-reconcile branch 2 times, most recently from 68a4236 to 5824fdf Compare July 1, 2024 12:16
@vincentmrg vincentmrg requested a review from antonincms July 1, 2024 12:16
@vincentmrg vincentmrg force-pushed the fix/firewallrules-concurency-reconcile branch from 5824fdf to 556304f Compare July 1, 2024 14:18
Copy link
Contributor

@antonincms antonincms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@vincentmrg vincentmrg merged commit f97a90d into main Jul 1, 2024
2 checks passed
@vincentmrg vincentmrg deleted the fix/firewallrules-concurency-reconcile branch July 1, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants