Move and rephrase the clause about zero Reliable Size #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So part of my issue as a reader is the second paragraph is focused on detailing one specific edge case of RESET_STREAM_AT. It's good to cover the edge case but I find it distracting to the primary use case. Therefore, propose moving it to the end of the section. At the same time, reword things slightly so it is clear this is just a special clause due to zero causing an effect like REST_STREAM. Attempts to fix #53
| Note that a Reliable Size value of zero is valid. A RESET_STREAM_AT frame with | ||
| this value is logically equivalent to a RESET_STREAM frame ({{Section 3.2 of | ||
| RFC9000}}). A sender MAY use either RESET_STREAM or RESET_STREAM_AT with a | ||
| Reliable Size of zero to avoid stream data delivery. |
There was a problem hiding this comment.
Technically, you don't avoid stream data delivery, you just don't commit.
There was a problem hiding this comment.
Split the difference and "Avoid committing "? 😃
kazuho
reviewed
Nov 27, 2023
Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
|
@marten-seemann @kazuho is this GTG? |
kazuho
approved these changes
Dec 1, 2023
marten-seemann
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So part of my issue as a reader is the second paragraph is focused on detailing one
specific edge case of RESET_STREAM_AT. It's good to cover the edge case but
I find it distracting to the primary use case. Therefore, propose moving it to the end
of the section. At the same time, reword things slightly so it is clear this is
just a special clause due to zero causing an effect like REST_STREAM.
Attempts to fix #53