Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QBtn repeat, removeChild guard, show|hidePromise catch #2213

Merged
merged 2 commits into from
Jun 28, 2018
Merged

QBtn repeat, removeChild guard, show|hidePromise catch #2213

merged 2 commits into from
Jun 28, 2018

Conversation

pdanpdan
Copy link
Collaborator

@pdanpdan pdanpdan commented Jun 28, 2018 •
edited
Loading

  • QBtn: fix multiple clicks and not working repeat
  • Guard removeChild
  • QDialog, QActionSheet: remove duplicate cancel emit (it's done in dismiss)
  • Add catch for showPromise and hidePromise in model-toggle on cancel
  • QModal: remove from DOM when closed

fix #2210

pdanpdan and others added 2 commits June 28, 2018 15:25
@pdanpdan
QBtn repeat, removeChild guard, show|hidePromise catch
e7a9cc5 
- QBtn: fix multiple clicks and not working repeat
- Guard removeChild
- QDialog, QActionSheet: remove duplicate cancel emit (it's done in dismiss)
- Add catch for showPromise and hidePromise in model-toggle on cancel
- QModal: remove from DOM when closed
@rstoenescu
Update scroll.js
6fb1c6d
@rstoenescu rstoenescu merged commit f26334e into quasarframework:dev Jun 28, 2018
@pdanpdan pdanpdan deleted the qbtn-qmodal branch June 28, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

q-tooltip in a q-button with loading attribute produces a console error message
2 participants
@pdanpdan @rstoenescu