Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of pre-release notebooks #6609

Merged

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented May 20, 2024

  • Update the stale list of pre-release notebooks by
    dropping notebooks that work with the last release 1.3.0
  • Enable notebook tests that pass at Cirq HEAD
  • Fix old instructions on installing pre-release cirq
  • Add missing import to examples/stabilizer_code.ipynb

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (f246c2b) to head (810da42).
Report is 1 commits behind head on main.

Current head 810da42 differs from pull request most recent head d141f22

Please upload reports for the commit d141f22 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6609   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1063     1063           
  Lines       91761    91761           
=======================================
+ Hits        89755    89759    +4     
+ Misses       2006     2002    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review May 21, 2024 01:30
@pavoljuhas pavoljuhas requested review from wcourtney, vtomole, cduck, verult and a team as code owners May 21, 2024 01:30
@pavoljuhas
Copy link
Collaborator Author

@verult - can you PTAL at your convenience?

Copy link
Collaborator

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed PR description!

@pavoljuhas pavoljuhas enabled auto-merge (squash) May 23, 2024 00:29
@pavoljuhas pavoljuhas merged commit 528b2d2 into quantumlib:main May 23, 2024
32 checks passed
@pavoljuhas pavoljuhas deleted the update-list-of-pre-release-notebooks branch May 23, 2024 01:23
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
- Update the stale list of pre-release notebooks by
  dropping notebooks that work with the last release 1.3.0
- Enable notebook tests that pass at Cirq HEAD
- Fix old instructions on installing pre-release cirq
- Add missing import to examples/stabilizer_code.ipynb

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants