Merge serializable_forms and deserialized_forms #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
wcourtney,
vtomole,
cduck and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6520 +/- ##
==========================================
- Coverage 97.78% 97.78% -0.01%
==========================================
Files 1105 1105
Lines 95109 95109
==========================================
- Hits 93000 92999 -1
- Misses 2109 2110 +1 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Mar 22, 2024
pavoljuhas
approved these changes
Mar 22, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
* Merge serializable_forms and deserialized_forms * Documentation for adding gates * Update documentation for adding CompilationTargetGatesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the experience of updating the supported gateset for
GridDevice.The original reasons of separating of
serializable_formsanddeserialized_formswere twofolds:FSimGateFamily(gates_to_accept=[cirq.CZ])does not acceptcirq.GateFamily(cirq.CZ), and similarly for other 2q gates.FSimGateFamily(gates_to_accept=[cirq.CZ])andcirq.GateFamily(cirq.CZ)were considered redundant for accepting the CZ gate).cirq.PhasedXZGateinstead ofcirq.GateFamily(cirq.PhasedXZGate)).I prefer to merge these fields now because
cirq.GateFamily(cirq.CZ)shouldn't be accepted by the gateset. Although rare, I don't think this is what we want.cc @wcourtney