Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test_docker_pre after pinning the mpmath transitive dependency #6481

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Enable test_docker_pre after pinning the mpmath transitive dependency #6481

merged 2 commits into from
Feb 28, 2024

Conversation

pavoljuhas
Copy link
Collaborator

Finalizes #6475

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 28, 2024
@pavoljuhas
Copy link
Collaborator Author

Note - fresh installation of pip install --pre cirq results in broken sympy.
This is fixed by mpmath version pin in #6477.

TODO: submit once #6477 is in the pre-release wheel.

@pavoljuhas pavoljuhas marked this pull request as ready for review February 28, 2024 16:53
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners February 28, 2024 16:53
@pavoljuhas pavoljuhas requested a review from viathor February 28, 2024 16:53
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (02d29a9) to head (6b21299).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6481   +/-   ##
=======================================
  Coverage   97.75%   97.76%           
=======================================
  Files        1105     1105           
  Lines       94925    94924    -1     
=======================================
+ Hits        92793    92798    +5     
+ Misses       2132     2126    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas merged commit eef7c5c into quantumlib:main Feb 28, 2024
34 checks passed
@pavoljuhas pavoljuhas deleted the enable-test_docker_pre branch February 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavoljuhas @NoureldinYosri @CirqBot