-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine RB and XEB to compute inferred errors #6455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be good if we could add a few things, either in this PR or the next one.
Maybe we could have a single function that the user calls which runs both 2Q XEB and 1Q RB and returns a CombinedXEBRBResult
. The CombinedXEBRBResult
would then need methods for returning and visualizing the 1Q error rates too. For the histogram method, we could plot 1Q and 2Q errors on the same axes (maybe something like result.histogram(single_qubit=True, two_qubit=True)
).
Thanks!
@eliottrosenberg I added the ability to plot both single and two qubit pauli errors The issue with a single function that runs both 2Q XEB and 1Q RB is the number of arguments which is not the best thing to have. That method will have 10+ arguments. alternatively I could group them into an |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6455 +/- ##
========================================
Coverage 97.82% 97.82%
========================================
Files 1115 1115
Lines 97337 97448 +111
========================================
+ Hits 95216 95327 +111
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
I'm thinking that most of the parameters would be shared. It could be something like this: Shared parameters:
RB:
XEB:
We can get rid of the |
@eliottrosenberg sg, I will add that method in a followup PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a final nit.
This PR:
InferredXEBResult
class which