Add documentation to cirq.decompose protocol regarding specific target gateset #6439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6439 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97121 97143 +22
=======================================
+ Hits 95000 95022 +22
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
| give an `intercepting_decomposer` to `cirq.decompose` that attempts to | ||
| target a specific gate set). | ||
| 2-qubit gates included by default in Cirq. If a custom decomposition is not | ||
| specified, Cirq will decompose all operations to X/Y/Z/CZ/Measurement + Global |
There was a problem hiding this comment.
I'm confused since these aren't universal? Is it missing PhasedX?
There was a problem hiding this comment.
I meant XPow/YPow/ZPow/CZPow; updated the docstring to clarify this.
|
@tanujkhattar Are we waiting on anything to merge this? |
|
@tanujkhattar Can we finish this off and commit it? |
…Cirq into decompose_document
|
@dstrain115 This is good to go now. |
…t gateset (quantumlib#6439) * Add documentation to cirq.decompose protocol regarding specific target gateset * Clarify docstring --------- Co-authored-by: Noureldin <noureldinyosri@google.com>
…t gateset (quantumlib#6439) * Add documentation to cirq.decompose protocol regarding specific target gateset * Clarify docstring --------- Co-authored-by: Noureldin <noureldinyosri@google.com>
Fixes #930