Fix font family for svg #6423
Merged
Fix font family for svg #6423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
vtomole,
cduck and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1111
Lines 97121 97143 +22
==========================================
+ Hits 95000 95018 +18
- Misses 2121 2125 +4 ☔ View full report in Codecov by Sentry. |
|
Did you verify some basic diagrams look basically correct? Assuming that, LGTM |
dabacon
approved these changes
Feb 2, 2024
|
@dabacon |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Fix font family for svg * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://matplotlib.org/3.5.0/api/font_manager_api.html#matplotlib.font_manager.FontProperties
Arialis not a valid font family with the only options being'sans-serif' (default), 'serif', 'cursive', 'fantasy', or 'monospace'The invalid input doesn't raise an error and instead fails silently with a warning message which is visible in the notebooks
As per https://github.com/matplotlib/matplotlib/blob/f0c4c41d1a08bc3f53824cddc8fef7f88fc52a43/lib/matplotlib/mpl-data/stylelib/seaborn-v0_8.mplstyle#L18 Arial is part of the
sans-seriffamily which is the default