Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert identity to phased xz in qubit characterization #6421

Merged
merged 1 commit into from
Jan 19, 2024
Merged

convert identity to phased xz in qubit characterization #6421

merged 1 commit into from
Jan 19, 2024

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Jan 19, 2024 •
edited
Loading

SingleQubitCliffordGates fail the gateset check of the grid device

Cirq/cirq-google/cirq_google/devices/grid_device.py

Lines 43 to 64 in a3eed6b

# Gate family constants used in various parts of GridDevice logic.
_PHASED_XZ_GATE_FAMILY = cirq.GateFamily(cirq.PhasedXZGate)
_MEASUREMENT_GATE_FAMILY = cirq.GateFamily(cirq.MeasurementGate)
_WAIT_GATE_FAMILY = cirq.GateFamily(cirq.WaitGate)
_SYC_FSIM_GATE_FAMILY = ops.FSimGateFamily(gates_to_accept=[ops.SYC])
_SQRT_ISWAP_FSIM_GATE_FAMILY = ops.FSimGateFamily(gates_to_accept=[cirq.SQRT_ISWAP])
_SQRT_ISWAP_INV_FSIM_GATE_FAMILY = ops.FSimGateFamily(gates_to_accept=[cirq.SQRT_ISWAP_INV])
_CZ_FSIM_GATE_FAMILY = ops.FSimGateFamily(gates_to_accept=[cirq.CZ])
# TODO(#5050) Add GlobalPhaseGate
# Target gates of `cirq_google.GoogleCZTargetGateset`.
_CZ_TARGET_GATES = [_CZ_FSIM_GATE_FAMILY, _PHASED_XZ_GATE_FAMILY, _MEASUREMENT_GATE_FAMILY]
# Target gates of `cirq_google.SycamoreTargetGateset`.
_SYC_TARGET_GATES = [_SYC_FSIM_GATE_FAMILY, _PHASED_XZ_GATE_FAMILY, _MEASUREMENT_GATE_FAMILY]
# Target gates of `cirq.SqrtIswapTargetGateset`
_SQRT_ISWAP_TARGET_GATES = [
_SQRT_ISWAP_FSIM_GATE_FAMILY,
_PHASED_XZ_GATE_FAMILY,
_MEASUREMENT_GATE_FAMILY,
]
. while the objects fail the check the operations themselves are supported but after coversion to a supported format like phased xz

this was missed from #6420

@NoureldinYosri NoureldinYosri requested review from mrwojtek, vtomole, cduck and a team as code owners January 19, 2024 18:02
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) January 19, 2024 18:03
@NoureldinYosri NoureldinYosri merged commit ba4c6aa into main Jan 19, 2024
36 checks passed
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@NoureldinYosri
convert identity to phased xz in qubit characterization (quantumlib#6421
da3efe9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@mrwojtek mrwojtek Awaiting requested review from mrwojtek mrwojtek is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoureldinYosri @tanujkhattar