Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change default for streaming feature flag to false (#6310)" #6380

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Revert "Change default for streaming feature flag to false (#6310)" #6380

merged 1 commit into from
Dec 12, 2023

Conversation

verult
Copy link
Collaborator

@verult verult commented Dec 11, 2023

This reverts commit 39bd926.

@verult verult requested a review from wcourtney December 11, 2023 21:52
@verult verult requested review from vtomole, cduck and a team as code owners December 11, 2023 21:52
@verult verult requested a review from dabacon December 11, 2023 21:52
wcourtney
wcourtney approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@wcourtney wcourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed offline, please make sure Eliott and Tyler are in the loop so that they can triage any new issues that might crop up.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33c2573) 97.81% compared to head (5745de1) 97.81%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6380   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1111     1111           
  Lines       96948    96948           
=======================================
  Hits        94825    94825           
  Misses       2123     2123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verult verult merged commit ec727ca into quantumlib:main Dec 12, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcourtney wcourtney wcourtney approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verult @wcourtney