Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for cirq google's support for google internal gates #6301

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

NoureldinYosri
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (455f50b) 97.89% compared to head (102dfac) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6301   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files        1108     1108           
  Lines       96210    96210           
=======================================
  Hits        94187    94187           
  Misses       2023     2023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => PyleGate translation Add documentation for InternalGate => Internal translation Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => Internal translation Add documentation for InternalGate => Internal gate implementations translation Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => Internal gate implementations translation Add documentation for cirq google's support for google internal gate implementations Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for cirq google's support for google internal gate implementations Add documentation for cirq google's support for google internal gates Oct 9, 2023
@NoureldinYosri NoureldinYosri marked this pull request as ready for review October 25, 2023 23:22
@dstrain115
Copy link
Collaborator

Do we need to link this doc via any TOC anywhere, cc @wcourtney ?

@NoureldinYosri
Copy link
Collaborator Author

@dstrain115 I don't think any of the cirq-google notebooks are indexed. For example https://quantumai.google/cirq/google/best_practices, https://quantumai.google/cirq/google/qubit-placement, ..etc

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) October 26, 2023 18:06
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) October 26, 2023 18:06
@NoureldinYosri NoureldinYosri merged commit 235a0c6 into master Oct 26, 2023
38 checks passed
@NoureldinYosri NoureldinYosri deleted the internal_gate_doc branch October 26, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants