Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering issue in random_rotations_between_grid_interaction_layer… #6261

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

andbe91
Copy link
Collaborator

@andbe91 andbe91 commented Aug 25, 2023

…s_circuit
Fixes #6260

Also added two test instances where one of them fails on the current master, but passes here.

@andbe91 andbe91 requested review from mrwojtek, vtomole, cduck and a team as code owners August 25, 2023 21:30
@andbe91 andbe91 requested a review from viathor August 25, 2023 21:30
@CirqBot CirqBot added the size: S 10< lines changed <50 label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (7ed95aa) 97.60% compared to head (b03d371) 97.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6261      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files        1116     1116              
  Lines       95848    95848              
==========================================
- Hits        93555    93552       -3     
- Misses       2293     2296       +3     
Files Changed Coverage Δ
...q/experiments/random_quantum_circuit_generation.py 98.73% <100.00%> (ø)
...eriments/random_quantum_circuit_generation_test.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar merged commit ed26d2f into quantumlib:master Aug 25, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

random_rotations_between_grid_interaction_layers_circuit output depends on the order of qubits in a pair
3 participants