Support the new quantum engine processor_selector in engine_client #6254
Conversation
jurruti
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
jurruti
force-pushed
the
quantum_engine
branch
from
f7b7e4f to
413a7f5
Compare
jurruti
force-pushed
the
quantum_engine
branch
from
413a7f5 to
b905657
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6254 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 1116 1116
Lines 95848 95911 +63
=======================================
+ Hits 93556 93618 +62
- Misses 2292 2293 +1
☔ View full report in Codecov by Sentry. |
| @@ -1090,3 +1123,40 @@ def _date_or_time_to_filter_expr(param_name: str, param: Union[datetime.datetime | |||
| f"type {type(param)}. Supported types: datetime.datetime and" | |||
| f"datetime.date" | |||
| ) | |||
|
|
|||
|
|
|||
| def _fix_create_job_processor_id_args_and_kwargs(args, kwargs): | |||
There was a problem hiding this comment.
Nit: omit "args_and_kwargs" from the name since they're already in the parameters list.
Also - since this is intended only to be used by the "rewrite" clause of the @deprecated_parameter, consider using that nomenclature and describing the action of the method, eg. rewrite_processor_ids_to_processor_id
|
In the last few commits I added the rewrite function to the deprecated parameter decorator. Now we only get requests for the quantum engine where |
The update is no longer a breaking change. Note that I force pushed (because the refactor was quite heavy), so most comments from the first round are outdated.