MatrixGate names don't survive serialization #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
approved these changes
Mar 3, 2023
cirq-core/cirq/ops/matrix_gates.py
Outdated
| @@ -114,11 +114,11 @@ def with_name(self, name: str) -> 'MatrixGate': | |||
| return MatrixGate(self._matrix, name=name, qid_shape=self._qid_shape, unitary_check=False) | |||
|
|
|||
| def _json_dict_(self) -> Dict[str, Any]: | |||
| return {'matrix': self._matrix.tolist(), 'qid_shape': self._qid_shape} | |||
| return {'matrix': self._matrix.tolist(), 'qid_shape': self._qid_shape, **({'name': self._name} if self._name else {})} | |||
There was a problem hiding this comment.
Strictly speaking this sends empty string to None after serialization+deserialization.
There was a problem hiding this comment.
Do we consider an empty string as a valid name? If so, I’ll update the check to more explicitly check None.
There was a problem hiding this comment.
Well, at present the empty string is accepted by the ctor, so let's make sure it works in serde, too.
There was a problem hiding this comment.
Good point. I've updated the check logic and added an empty name test.
richrines1
added a commit
to Infleqtion/client-superstaq
that referenced
this pull request
Jul 25, 2023
fixes #637 (this was broken by #626, but didn't show up because quantumlib/Cirq#6026 wasn't merged into non-dev cirq until version 1.2.0)
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5999