Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy type check errors due to sympy update #5836

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix mypy type check errors due to sympy update #5836

merged 3 commits into from
Aug 25, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #5835

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners August 25, 2022 20:28
@CirqBot CirqBot added the size: S 10< lines changed <50 label Aug 25, 2022
tanujkhattar
tanujkhattar commented Aug 25, 2022
View reviewed changes
Copy link
Collaborator Author

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint errors.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 25, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 25, 2022
@CirqBot CirqBot merged commit 994dba1 into quantumlib:master Aug 25, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 25, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Fix mypy type check errors due to sympy update (quantumlib#5836)
1ee3a9b 
Fixes quantumlib#5835
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Fix mypy type check errors due to sympy update (quantumlib#5836)
fe5cb68 
Fixes quantumlib#5835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon left review comments

@mpharrigan mpharrigan mpharrigan approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy tests failing on master due to sympy 1.11
4 participants
@tanujkhattar @dabacon @mpharrigan @CirqBot