Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete sentences #5741

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

augustehirth
Copy link
Collaborator

Fixing #5734

@augustehirth augustehirth requested review from a team, vtomole and cduck as code owners July 12, 2022 20:52
@augustehirth augustehirth requested a review from viathor July 12, 2022 20:52
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 12, 2022
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits.

@@ -611,7 +611,7 @@
"id": "B8ciZZSSf2jb"
},
"source": [
"Another example is the 3-qubit Toffoli gate, which is equivalent to a controlled-controlled-X gate. Many devices do not support a three qubit gate, so it is important "
"Another example is the 3-qubit Toffoli gate, which is equivalent to a controlled-controlled-X gate. Many devices do not support a three qubit gate, so it is important to decompose this into one and two qubit gates."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Many devices do not support three qubit gates, so it is important to decompose them into one and two qubit gates.

(Removes "a", changes "gate" to "gates" and "this" to "them".)

@@ -680,7 +680,7 @@
"source": [
"## Next steps\n",
"\n",
"After completing this tutorial, you should be able to use gates and operations to construct your own quantum circuits, simulate them, and to use sweeps. It should give you a brief idea of the commonly used \n",
"After completing this tutorial, you should be able to use gates and operations to construct your own quantum circuits, simulate them, and to use sweeps.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: use "to" (as in "to do") consistently in each item on the list:

"to construct your own quantum circuits, to simulate them, and to use sweeps."

(Adds "to" in front of "simulate".)

@augustehirth augustehirth removed the request for review from tanujkhattar July 12, 2022 21:08
@augustehirth augustehirth added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit 8246c5b into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
@augustehirth augustehirth deleted the basics_incomplete_sentences branch July 12, 2022 22:09
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants