-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Fourier Checking tutorial #5708
Conversation
dstrain115
commented
Jul 10, 2022
•
edited
Loading
edited
- Miscellaenous fixes for Fourier Checking
- Fix top block was code not text
- Fix latex blocks in various places
- Improve docstrings and typing for functions
- A few miscellaenous wording improvements.
- Change Foxtail to Sycamore since Foxtail is deprecated. - Add some clarification that instructions are for linux.
- Miscellaenous fixes for Fourier Checking - Fix top block was code not text - Fix latex blocks in various places - Improve docstrings and typing for functions - A few miscellaenous wording improvements.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -32,12 +32,10 @@ | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an artifact of ReviewNB. I don't see anything in the source that could cause this, it doesn't appear in the github viewer, and, if you hide previous version in ReviewNB, it disappears. I will commit this and double-check that it doesn't show up on the website, but I think it is just a reviewnb glitch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One line still looks messed to me but otherwise LGTM
- Miscellaenous fixes for Fourier Checking - Fix top block was code not text - Fix latex blocks in various places - Improve docstrings and typing for functions - A few miscellaenous wording improvements.