-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove 2 deprecated create_device_proto_* methods for v0.16 release #5704
remove 2 deprecated create_device_proto_* methods for v0.16 release #5704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm chatting with @maffoo to verify that it's OK to merge removal PRs before server-side changes are in for Cirq 0.15 deprecations. Until then let's hold off on merging
[cirq_google.FSIM_GATESET], | ||
known_devices._SYCAMORE_DURATIONS_PICOS, | ||
) | ||
device_info, _ = _create_device_spec_with_horizontal_couplings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test can be removed, since we no longer need to be backward compatible with SerializableGateSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Synced with @maffoo - we'll merge all the removals before updating Pyle. |
…uantumlib#5704) This is the 1st task under "Remove deprecations" section in quantumlib#5050
This is the 1st task under "Remove deprecations" section in #5050