Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Cauldron of Doc fixes #5680

Merged
merged 11 commits into from
Jul 10, 2022
Merged

Conversation

dstrain115
Copy link
Collaborator

Miscellaneous doc fixes around cirq
- Fix indenting where it is inappropriately detected as blockquotes
- Fix references and commas at a few places.
- Move some docstrings from init to class so that they show up on
the API reference properly.
- Fix list formatting
- Fix one-line summaries that are more than one line.

- Change Foxtail to Sycamore since Foxtail is deprecated.
- Add some clarification that instructions are for linux.
Miscellaneous doc fixes around cirq
- Fix indenting where it is inappropriately detected as blockquotes
- Fix references and commas at a few places.
- Move some docstrings from init to class so that they show up on
the API reference properly.
- Fix list formatting
- Fix one-line summaries that are more than one line.
@dstrain115 dstrain115 requested review from a team, vtomole, cduck, wcourtney and verult as code owners July 7, 2022 21:03
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 7, 2022
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments but otherwise LGTM

$\sum tensor_{i_0,...,i_{r-1},j_0,...,j_{r-1}} *
More specifically, this computes:

$$i
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an extra "i"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Calibration objects instead of using this directly.
"""Client for the Quantum Engine API handling protos and gRPC client.

Thie is the client for the Quantum Engine API that deals with the engine protos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thie -> This

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

served by using the `Engine`, `EngineProgram`, `EngineJob`, `EngineProcessor`, and
`Calibration` objects instead of using this directly.

Args:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this render correctly on doc site? I thought you should keep the args in the init but put a description on the class for the best redering?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to this style.

@dstrain115 dstrain115 added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 10, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 10, 2022
@CirqBot CirqBot merged commit 77b61f5 into quantumlib:master Jul 10, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 10, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Miscellaneous doc fixes around cirq
    - Fix indenting where it is inappropriately detected as blockquotes
    - Fix references and commas at a few places.
    - Move some docstrings from init to class so that they show up on
    the API reference properly.
    - Fix list formatting
    - Fix one-line summaries that are more than one line.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Miscellaneous doc fixes around cirq
    - Fix indenting where it is inappropriately detected as blockquotes
    - Fix references and commas at a few places.
    - Move some docstrings from init to class so that they show up on
    the API reference properly.
    - Fix list formatting
    - Fix one-line summaries that are more than one line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants