Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special CXPowGate.on. #5471

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Remove special CXPowGate.on. #5471

merged 3 commits into from
Jun 8, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

Fixes #3011

@MichaelBroughton MichaelBroughton added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Jun 8, 2022
@MichaelBroughton MichaelBroughton requested review from a team, vtomole and cduck as code owners June 8, 2022 20:05
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 8, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 8, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 8, 2022
@CirqBot CirqBot merged commit 9bead0b into quantumlib:master Jun 8, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 8, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@MichaelBroughton @rht
Remove special CXPowGate.on. (quantumlib#5471)
421b899 
Fixes quantumlib#3011
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@MichaelBroughton
Remove special CXPowGate.on. (quantumlib#5471)
ac84f1f 
Fixes quantumlib#3011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
BREAKING CHANGE For pull requests that are important to mention in release notes. size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find a better pattern for implementing control and target keywords and us for control gates.
3 participants
@MichaelBroughton @viathor @CirqBot