Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush missed v0.13 backlog items. #4600

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Flush missed v0.13 backlog items. #4600

merged 4 commits into from
Oct 26, 2021

Conversation

MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Oct 26, 2021 •
edited
Loading

Missed these in the original flush here #4567

@MichaelBroughton MichaelBroughton requested review from cduck, vtomole and a team as code owners October 26, 2021 01:37
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Oct 26, 2021
@CirqBot CirqBot added the size: M 50< lines changed <250 label Oct 26, 2021
tanujkhattar
tanujkhattar approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update gate_operation.py.

Cirq/cirq-core/cirq/ops/gate_operation.py

Line 225 in 954a7b6

getter = getattr(self.gate, '_measurement_key_', None)

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 26, 2021
@CirqBot CirqBot merged commit 009b3da into quantumlib:master Oct 26, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 26, 2021
@MichaelBroughton MichaelBroughton deleted the v13_flush branch October 26, 2021 02:40
MichaelBroughton added a commit that referenced this pull request Oct 26, 2021
@MichaelBroughton
Flush missed v0.13 backlog items. (#4600)
7d74e3c 
Missed these in the original flush here #4567
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@MichaelBroughton @rht
Flush missed v0.13 backlog items. (quantumlib#4600)
1044ad6 
Missed these in the original flush here quantumlib#4567
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@MichaelBroughton
Flush missed v0.13 backlog items. (quantumlib#4600)
366de97 
Missed these in the original flush here quantumlib#4567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelBroughton @tanujkhattar @CirqBot