Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracting cirq-ionq #4205

Merged
merged 11 commits into from
Jun 17, 2021
Merged

Extracting cirq-ionq #4205

merged 11 commits into from
Jun 17, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jun 15, 2021 •
edited
Loading

Extracts cirq-ionq as a separate package.

Test PyPi upload: https://test.pypi.org/project/cirq-ionq/0.12.0.dev20210614184222/

@balopat balopat requested a review from dabacon June 15, 2021 01:40
@balopat balopat requested a review from viathor June 15, 2021 01:40
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 15, 2021
@balopat balopat marked this pull request as draft June 15, 2021 01:49
@balopat balopat removed request for dabacon and viathor June 15, 2021 01:49
dabacon
dabacon approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @balopat ! Was thinking it would be on me :)

cirq-ionq/cirq_ionq/json_test_data/__init__.py Outdated Show resolved Hide resolved
cirq-ionq/setup.py Outdated Show resolved Hide resolved
@balopat
Copy link
Contributor Author

balopat commented Jun 15, 2021

Thanks for this @balopat ! Was thinking it would be on me :)

Feel free to jump in and add commits to my branch!!!

vtomole
vtomole reviewed Jun 15, 2021
View reviewed changes
cirq-ionq/README.rst Outdated Show resolved Hide resolved
@balopat balopat marked this pull request as ready for review June 16, 2021 00:35
@balopat balopat requested review from ma5x and pschindler as code owners June 16, 2021 00:35
viathor
viathor approved these changes Jun 16, 2021
View reviewed changes
cirq-aqt/setup.py Outdated Show resolved Hide resolved
vtomole
vtomole previously requested changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ./cirq-ionq like so #4221

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 17, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 17, 2021
@CirqBot CirqBot merged commit 566ce2b into quantumlib:master Jun 17, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 17, 2021
@balopat balopat mentioned this pull request Jun 17, 2021
Merged
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@balopat @rht
Extracting cirq-ionq (quantumlib#4205)
5504f99 
Extracts cirq-ionq as a separate package.

Test PyPi upload: https://test.pypi.org/project/cirq-ionq/0.12.0.dev20210614184222/
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@balopat
Extracting cirq-ionq (quantumlib#4205)
dc0d520 
Extracts cirq-ionq as a separate package.

Test PyPi upload: https://test.pypi.org/project/cirq-ionq/0.12.0.dev20210614184222/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@dabacon dabacon dabacon approved these changes

@vtomole vtomole vtomole left review comments

@cduck cduck Awaiting requested review from cduck

@ColemanCollins ColemanCollins Awaiting requested review from ColemanCollins

@gmauricio gmauricio Awaiting requested review from gmauricio

@nakardo nakardo Awaiting requested review from nakardo

@ma5x ma5x Awaiting requested review from ma5x

@pschindler pschindler Awaiting requested review from pschindler

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@balopat @dabacon @vtomole @viathor @CirqBot