Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some shellcheck warnings in 'get to repo root' script code #1741

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix some shellcheck warnings in 'get to repo root' script code #1741

merged 2 commits into from
Jun 24, 2019

Conversation

Strilanc
Copy link
Contributor

@fvkg mentioned this tool shellcheck. It produces a lot of useful warnings about our scripts, mostly related to undesired word splitting if strings happen to contain spaces.

@Strilanc Strilanc requested a review from maffoo June 24, 2019 20:43
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jun 24, 2019
@fvkg
Copy link
Contributor

fvkg commented Jun 24, 2019

This is a very ambitious crossover episode.

vtomole
vtomole approved these changes Jun 24, 2019
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 24, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 24, 2019
@CirqBot CirqBot merged commit 5499dac into master Jun 24, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 24, 2019
@CirqBot CirqBot deleted the shellcheck branch June 24, 2019 22:53
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvkg fvkg fvkg approved these changes

@vtomole vtomole vtomole approved these changes

@maffoo maffoo Awaiting requested review from maffoo

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Strilanc @fvkg @vtomole @googlebot @CirqBot