Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitSweep should be UNIT_SWEEP #5617

Closed
dabacon opened this issue Jun 24, 2022 · 2 comments · Fixed by #6518 or senecameeks/Cirq#1
Closed

UnitSweep should be UNIT_SWEEP #5617

dabacon opened this issue Jun 24, 2022 · 2 comments · Fixed by #6518 or senecameeks/Cirq#1
Assignees
@dstrain115
Labels
area/parameters parameter resolution, parameterized gates, operations kind/bug-report Something doesn't seem to work. kind/health For CI/testing/release process/refactoring/technical debt items triage/wont-fix Decided against going forward with this

Comments

@dabacon
Copy link
Collaborator

dabacon commented Jun 24, 2022

It's a constant, not a class.
@dabacon dabacon added the kind/bug-report Something doesn't seem to work. label Jun 24, 2022
@dabacon dabacon changed the title UnitSweep should be UNIT_SWEE UnitSweep should be UNIT_SWEEP Jun 25, 2022
@viathor viathor added kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on area/parameters parameter resolution, parameterized gates, operations labels Jun 27, 2022
@dstrain115
Copy link
Collaborator

Discussion: This is a singleton, but it has a different convention than some of the other sweeps.
For consistency with other sweeps, we may want to keep this as camel case.
Other singletons such as Sycamore, Foxtail, also, follow camelcase convention.

@dstrain115 dstrain115 added triage/wont-fix Decided against going forward with this and removed triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on time/before-1.0 labels Jun 29, 2022
@dabacon
Copy link
Collaborator Author

dabacon commented Jun 29, 2022

Some of the singletons don't though: Pauli.X, all our gate constants follow the correct style rule as well. This may be easy for us to remember, but for users coming in from the outside a strong consistency in style is very helpful. For example knowing the cirq.CNOT is a gate instance is useful in that there is often confusion when learning Cirq about gate classes, gate instances, and op instances.

@dstrain115 dstrain115 self-assigned this Mar 21, 2024
dstrain115 added a commit to dstrain115/Cirq-1 that referenced this issue Mar 22, 2024
@dstrain115
Add UNIT_SWEEP as an alias for UnitSweep
8c7fe3f 
Since this is a singleton, it should use constant naming.
Since it should also stay consistent with other Sweeps (and for
backwards compatibility), we will keep the old name as well.

Fixes: quantumlib#5617
@dstrain115 dstrain115 mentioned this issue Mar 22, 2024
Merged
dstrain115 added a commit that referenced this issue Mar 22, 2024
@dstrain115
Add UNIT_SWEEP as an alias for UnitSweep (#6518)
edda3a5 
Since this is a singleton, it should use constant naming.
Since it should also stay consistent with other Sweeps (and for
backwards compatibility), we will keep the old name as well.

Fixes: #5617
@senecameeks senecameeks mentioned this issue Mar 22, 2024
Merged
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this issue May 28, 2024
@dstrain115 @jselig-rigetti
Add UNIT_SWEEP as an alias for UnitSweep (quantumlib#6518)
ce3757c 
Since this is a singleton, it should use constant naming.
Since it should also stay consistent with other Sweeps (and for
backwards compatibility), we will keep the old name as well.

Fixes: quantumlib#5617
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@dstrain115
Add UNIT_SWEEP as an alias for UnitSweep (quantumlib#6518)
d3b7fe5 
Since this is a singleton, it should use constant naming.
Since it should also stay consistent with other Sweeps (and for
backwards compatibility), we will keep the old name as well.

Fixes: quantumlib#5617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstrain115 dstrain115

Labels
area/parameters parameter resolution, parameterized gates, operations kind/bug-report Something doesn't seem to work. kind/health For CI/testing/release process/refactoring/technical debt items triage/wont-fix Decided against going forward with this
Projects
None yet
Milestone
No milestone
3 participants
@dabacon @dstrain115 @viathor