Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Telemetry Metrics #415

Closed
maennchen opened this issue Jul 22, 2019 · 7 comments · Fixed by #453
Closed

Expose Telemetry Metrics #415

maennchen opened this issue Jul 22, 2019 · 7 comments · Fixed by #453
Assignees

Comments

@maennchen
Copy link
Member

Expose Metrics via Telemetry

@mrmarcsmith
Copy link
Contributor

@maennchen I'm happy to explore opening a PR for this. Is this something you have started? if not, Is there any chance you could give me a shove in the right direction as far as a high level plan? You know this project better than anyone so a little bit of help from you could save me a LOT of time.

@mrmarcsmith
Copy link
Contributor

@maennchen if you have time, a quick reply could help me get started on this.

@maennchen
Copy link
Member Author

@mrmarcsmith Sorry, i don't really have time right now. I'm on vacation until next week.

It'd be awesome to get a PR with this feature.

I have thought about this at some point. I thought that at least the following events should be recorded:

  • add job
  • delete job
  • update job
  • job execution (including return value / error / execution time)

The first three should probably be added to the JobBroadcaster module and the execution in the Executor module.

@mrmarcsmith
Copy link
Contributor

That should be enough to get me started! Thank you for replying while on vacation.

@maennchen
Copy link
Member Author

Replaced by #453

@maennchen
Copy link
Member Author

@mrmarcsmith Released as v3.2.0 ❤️

@mrmarcsmith
Copy link
Contributor

Thank you @maennchen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants