Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the gst l4 notebook #302

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fixed the gst l4 notebook #302

merged 1 commit into from
Mar 11, 2019

Conversation

quantopiancal
Copy link
Contributor

@quantopiancal quantopiancal commented Mar 11, 2019 •
edited
Loading

Fixed a bug created by an Alphalens change. Related to #2787

@richafrank
Copy link
Member

LGTM.

Is the semicolon at EOL intentional?

@richafrank richafrank mentioned this pull request Mar 11, 2019
Closed
@jmccorriston
Copy link
Contributor

jmccorriston commented Mar 11, 2019 •
edited
Loading

I believe the semicolon hides a print of the plot name. I'm probably explaining that incorrectly but it cleans up the output a bit!

@richafrank
Copy link
Member

I believe the semicolon hides a print of the plot name. I'm probably explaining that incorrectly but it cleans up the output a bit!

Ok, cool. I'm vaguely aware of that.

@quantopiancal quantopiancal merged commit f5445c5 into master Mar 11, 2019
@quantopiancal quantopiancal deleted the fixing-gst-l4-nb branch March 11, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richafrank richafrank richafrank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quantopiancal @richafrank @jmccorriston