Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated history calls in futures tut to use new API. #184

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

ernestoeperez88
Copy link

No description provided.

@@ -63,7 +63,7 @@
{
"data": {
"text/plain": [
"Future(1058201601, symbol=u'CLF16', root_symbol=u'CL', asset_name=u'Light Sweet Crude Oil', exchange=u'NYMEX', start_date=Timestamp('2012-01-19 00:00:00+0000', tz='UTC'), end_date=Timestamp('2015-12-21 00:00:00+0000', tz='UTC'), first_traded=None, notice_date=Timestamp('2015-12-23 00:00:00+0000', tz='UTC'), expiration_date=Timestamp('2015-12-21 00:00:00+0000', tz='UTC'), auto_close_date=Timestamp('2015-12-17 00:00:00+0000', tz='UTC'), tick_size=0.01, multiplier=1000.0, exchange_full=u'NYMEX')"
"Future(1058201601 [CLF16])"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer include all the other information as part of the futures object?

Copy link
Author

@ernestoeperez88 ernestoeperez88 Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we updated the string representations of continuous futures and contracts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just an update to the representation? Can I still get the root_symbol or the exchange or expiration_date?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct.

"\n",
" frequency : {'daily', 'minute'}, optional\n",
" Resolution of the data to be returned. Defaults to 'daily'.\n",
" 'close_price', 'volume', 'contract'}.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default returns OHLCV, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Default being no input to fields)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like we removed default parameters. I need to update the wording.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that's the docstring xD I thought it was part of the notebook/tutorial text. Nothing to update here.

Copy link
Contributor

@mmargenot mmargenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestoeperez88 ernestoeperez88 merged commit 5358bce into master Oct 4, 2017
@ernestoeperez88 ernestoeperez88 deleted the fix_futures_tut_history branch October 4, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants