fix(jetty12): more align RequestURI attr creation with that of Jetty 11 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the path part of the URI in raw format. Signed-off-by: You Aoki <165284116+marinedayo@users.noreply.github.com>
marinedayo
force-pushed
the
more-align-requesturi-in-jetty-12
branch
from
b4a0fb0 to
8f01a11
Compare
sondemar
reviewed
Apr 17, 2024
| @@ -68,7 +68,7 @@ public void getRequest() throws Exception { | |||
|
|
|||
| @Test | |||
| public void eventGoesToAppenders() throws Exception { | |||
| URL url = new URL(JETTY_FIXTURE.getUrl()); | |||
| URL url = new URL("http://localhost:" + RANDOM_SERVER_PORT + "/path/foo%20bar;param?query#fragment"); | |||
There was a problem hiding this comment.
optional: How about leaving it as it was to maintain the same entry point?
Suggested change
| URL url = new URL("http://localhost:" + RANDOM_SERVER_PORT + "/path/foo%20bar;param?query#fragment"); | |
| URL url = new URL(JETTY_FIXTURE.getUrl() + "path/foo%20bar;param?query#fragment"); |
There was a problem hiding this comment.
Thanks for your reply.
53b341a done.
sondemar
reviewed
Apr 17, 2024
| @@ -68,7 +68,7 @@ public void getRequest() throws Exception { | |||
|
|
|||
| @Test | |||
| public void eventGoesToAppenders() throws Exception { | |||
| URL url = new URL(JETTY_FIXTURE.getUrl()); | |||
| URL url = new URL("http://localhost:" + RANDOM_SERVER_PORT + "/path/foo%20bar;param?query#fragment"); | |||
sondemar
approved these changes
Apr 17, 2024
Signed-off-by: You Aoki <165284116+marinedayo@users.noreply.github.com>
|
Hi @ceki , could you please review and merge? Thanks. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #4 (comment)
Why
By the following pull request, now provides the path part of the URI in Jetty 12 as well.
However,
HttpURI::getDecodedPathmethod returns a decoded path, so the behavior is different from other environments, such as Jetty 11.What
HttpURI::getPathmethod instead, which returns the raw format