This repository has been archived by the owner on Jun 19, 2021. It is now read-only.
Simple/Expert UI changer #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One problem I'm still trying to figure out is why the gear menu opens the menu 200 pixel below the window, rather than inside the window. |
|
Right now, the menu opens at a specific position relative to (I believe) the top left corner. It would probably be better to define its position from one of the bottom corners, to avoid issues like this when the window size changes. |
skullydazed
force-pushed
the
expert_ui
branch
2 times, most recently
from
da626fd to
c959117
Compare
skullydazed
force-pushed
the
expert_ui
branch
2 times, most recently
from
d12ff3a to
adb438c
Compare
|
I'm pretty happy with how this works now. I need to test on windows and in packaged versions, but if it looks good there I'm ready to merge this. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened a new PR because #24 got too complicated after the restructuring.