Fix RGB_DISABLE_TIMEOUT overflow warning (#9866) #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Jul 30, 2020
fauxpark
requested changes
Jul 30, 2020
fauxpark
approved these changes
Jul 31, 2020
drashna
approved these changes
Aug 5, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 9, 2020
fdawans
pushed a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
fdawans
added a commit
to fdawans/qmk_firmware
that referenced
this pull request
Aug 11, 2020
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
fcoury
pushed a commit
to fcoury/qmk_firmware_archive
that referenced
this pull request
Sep 20, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces long integer math in the expansion of
RGB_DISABLE_TIMEOUTwhen a config file uses the deprecated defineRGB_DISABLE_AFTER_TIMEOUTto prevent overflow with values greater than 27.Types of Changes
Issues Fixed or Closed by This PR
Checklist