Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate udev rules into a single file #9693

Merged
merged 10 commits into from
Sep 27, 2020

Conversation

fauxpark
Copy link
Member

Description

Merged the udev rules files into a single file, and tweaked it a bit to include all USB devices under the known Caterina VIDs, and add some missing rules (USBAspLoader, SAM-BA).

Also, while I was here, I removed some outdated FAQ items.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 10, 2020 03:18
@fauxpark fauxpark force-pushed the udev-rules-consolidation branch from 10bc105 to c74bd64 Compare July 10, 2020 03:19
@Erovia
Copy link
Member

Erovia commented Jul 11, 2020

What's the advantage of having one file instead of having one file per bootloader?

@fauxpark
Copy link
Member Author

Less copypasting, and it should be easier for users who don't know what their board's bootloader is.
I'm not sure what the advantage of having multiple files would be - the unused rules shouldn't interfere with non-bootloader devices anyway.

Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have another "old" rule. Probably we should link to the recommended rules instead of duplicating them here.

lib/python/qmk/cli/doctor.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/doctor.py Outdated Show resolved Hide resolved
@fauxpark fauxpark requested review from Erovia and a team July 12, 2020 15:38
@drashna drashna requested a review from a team July 24, 2020 07:16
@fauxpark fauxpark force-pushed the udev-rules-consolidation branch from ae9366d to c2a0ceb Compare September 18, 2020 19:23
@fauxpark fauxpark merged commit e7acd39 into qmk:master Sep 27, 2020
@fauxpark fauxpark deleted the udev-rules-consolidation branch September 27, 2020 10:36
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Consolidate udev rules into a single file

* Update rules in doctor.py

* Simplify doctor rule checking

* Fix errors

* Add TMK "FEED" VID to list of deprecated udev rules

* A comma would be nice

* Split rules back up into bootloaders

* Link to docs page in "missing" case

* Add Pololu VID

* Be more specific about Caterina devices, and add LilyPad PID
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Consolidate udev rules into a single file

* Update rules in doctor.py

* Simplify doctor rule checking

* Fix errors

* Add TMK "FEED" VID to list of deprecated udev rules

* A comma would be nice

* Split rules back up into bootloaders

* Link to docs page in "missing" case

* Add Pololu VID

* Be more specific about Caterina devices, and add LilyPad PID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants