-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ext65rev2 - New Keyboard #9482
Merged
Merged
Ext65rev2 - New Keyboard #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Jun 21, 2020
keyboards/aeboards/ext65rev2/boards/ST_STM32F072B_DISCOVERY/board.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Challis <git@zvecr.com>
drashna
approved these changes
Jul 5, 2020
fauxpark
requested changes
Jul 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be moved under the existing ext65 directory as a /rev2
?
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
requested changes
Jul 27, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
I don't know why the base branch is set to |
Zvecr said it was a breaking change @noroadsleft |
looks Ah, it was at that time, but it's not anymore. |
noroadsleft
removed
the
breaking_change
Changes that need to wait for a version increment
label
Aug 8, 2020
noroadsleft
approved these changes
Aug 8, 2020
fauxpark
requested changes
Aug 8, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
* ext65rev2 initial * open drain change and config * pwm * pwm streams * spi * ws2812 spi * oled * enable sleep * keymap and dissable oled * readd oleds * nooled * led_update_kb revised * update and remove board specific files and add to ext65rev2.c * Update OLED usb status * Update keyboards led state * Layer state set kb * Return state * Update keyboards led state * Update OLED usb status * merge master and merge rev folders * add readme * move board_init to only if OLED is enabled * update readme * update rules.mk * Remove OLED from rules.mk * Update config.h * show AEBoards * Update keyboards/aeboards/ext65/rev2/rules.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Ext65Rev2 PCB since #9414 was merged.
Refactor Rev1 and Rev2 into EXT65
Types of Changes
Issues Fixed or Closed by This PR
Checklist