Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klackygears add user and handwired brain #9154

Merged
merged 17 commits into from
Jun 28, 2020
Merged

Klackygears add user and handwired brain #9154

merged 17 commits into from
Jun 28, 2020

Conversation

Klackygears
Copy link
Contributor

@Klackygears Klackygears commented May 21, 2020 •
edited by Erovia
Loading

Adding userspace and handwired keyboard

Description

Adding in userspace for future updates and handwired brain keyboard. Let me know if this works! I'm not sure how to handle the submodules.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes May 21, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current form, this PR cannot be accepted due to the submodule changes in lib/chibios, lib/chibios-contrib, lib/ugfx.

@zvecr zvecr requested a review from a team May 21, 2020 16:04
@Klackygears
Copy link
Contributor Author

How do I correct those submodule changes?

@Klackygears
Copy link
Contributor Author

I think I corrected the submodule changes. Please, double check!

@Klackygears Klackygears requested review from zvecr and removed request for a team May 29, 2020 16:20
@noroadsleft noroadsleft requested a review from a team June 1, 2020 21:39
drashna
drashna requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ideally, this should be a keyboard and a keymap/userspace PR, separately, rather than a single PR.

keyboards/handwired/brain/brain.c Outdated Show resolved Hide resolved
keyboards/handwired/brain/brain.h Outdated Show resolved Hide resolved
keyboards/handwired/brain/brain.h Outdated Show resolved Hide resolved
keyboards/handwired/brain/config.h Outdated Show resolved Hide resolved
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
users/klackygears/klackygears.h Outdated Show resolved Hide resolved
users/klackygears/klackygears.h Outdated Show resolved Hide resolved
users/klackygears/klackygears.h Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Show resolved Hide resolved
users/klackygears/ReadMe.md Outdated Show resolved Hide resolved
@Klackygears Klackygears requested a review from drashna June 5, 2020 17:18
@Klackygears
Copy link
Contributor Author

I made a mistake and had to do a lot of clean-up! Sorry for the trouble! Is it okay to leave as-is or should I submit a new pr?

drashna
drashna requested changes Jun 8, 2020
View reviewed changes
keyboards/handwired/brain/config.h Outdated Show resolved Hide resolved
keyboards/handwired/brain/config.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jun 8, 2020

I made a mistake and had to do a lot of clean-up! Sorry for the trouble! Is it okay to leave as-is or should I submit a new pr?

The cleanup is fine. We tend to squash PRs, so it ends up as a single commit, without all of the history/fixing.

@Klackygears
Copy link
Contributor Author

Okay, I think it's ready for another review!

@Klackygears Klackygears requested a review from drashna June 8, 2020 14:02
Erovia
Erovia requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd run qmk cformat on all the sources, just to tidy up the formatting.

keyboards/handwired/brain/rules.mk Outdated Show resolved Hide resolved
users/klackygears/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jun 16, 2020
View reviewed changes
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/brain/keymaps/default/keymap.c Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Outdated Show resolved Hide resolved
users/klackygears/tap_dances.c Outdated Show resolved Hide resolved
@Klackygears Klackygears requested a review from fauxpark June 17, 2020 15:33
fauxpark
fauxpark requested changes Jun 17, 2020
View reviewed changes
keyboards/handwired/brain/rules.mk Outdated Show resolved Hide resolved
users/klackygears/klackygears.h Outdated Show resolved Hide resolved
@Klackygears Klackygears requested a review from fauxpark June 18, 2020 01:32
fauxpark
fauxpark requested changes Jun 23, 2020
View reviewed changes
users/klackygears/klackygears.c Outdated Show resolved Hide resolved
@Klackygears @fauxpark
Update users/klackygears/klackygears.c
739f543 
Co-authored-by: Ryan <fauxpark@gmail.com>
@Erovia Erovia requested a review from a team June 27, 2020 20:31
@Klackygears @Erovia
Update keyboards/handwired/brain/keymaps/default/keymap.c
fce5a9b 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@Erovia Erovia merged commit d36d5ec into qmk:master Jun 28, 2020
@Klackygears
Copy link
Contributor Author

@Erovia I don't think I ever told you thanks for merging this! I appreciate it! Thanks!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Klackygears @fauxpark
@Erovia @jakobaa
Klackygears add user and handwired brain (qmk#9154)
6726520 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@Klackygears Klackygears deleted the klackygears_user branch July 10, 2020 16:56
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Klackygears @fauxpark @Erovia
Klackygears add user and handwired brain (qmk#9154)
9413245 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Klackygears @drashna @Erovia @fauxpark @zvecr