Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Via support to ALPS64 #9041

Merged
merged 1 commit into from
May 19, 2020
Merged

Add Via support to ALPS64 #9041

merged 1 commit into from
May 19, 2020

Conversation

jja2000
Copy link
Contributor

@jja2000 jja2000 commented May 7, 2020

Description

I've added support for via to the alps64 based on the documentation and the commits of other boards that already have support.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keyboards/alps64/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/alps64/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/alps64/config.h Outdated Show resolved Hide resolved
@zvecr zvecr added the via Adds via keymap and/or updates keyboard for via support label May 15, 2020
@drashna drashna merged commit 32d03db into qmk:master May 19, 2020
binjeh added a commit to binjeh/qmk_firmware that referenced this pull request May 20, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (606 commits)
  Reintegrate previous docker docs (qmk#9084)
  Add VIA Keymap to Liminal Directory (qmk#8965)
  Adding Chimera Ortho Plus (qmk#9093)
  Added custom keymap with french mac layout. (qmk#9115)
  Art userspace (qmk#9068)
  Add Via support to the YMD09 (qmk#9108)
  Candybar: VIA support for lefty and righty (qmk#9066)
  Gherkin 26, 27, 28, 30 keys compatibility (qmk#9136)
  MSYS2 install: bodge out avrdude package installation for USBaspLoader
  Disable Mousekey Command interface when Constant speed is enabled (qmk#7017)
  [Keyboard] Add Bakeneko 80 keyboard (qmk#9118)
  [Keymap] Add Via support to ALPS64 (qmk#9041)
  [Keyboard] add kbdfans/maja rgb keyboard (qmk#9114)
  [Keyboard] Add NumDiscipline Keyboard - Modified Version of Discipline With Numpad (qmk#9112)
  Streamline the macos install process
  [Docs] Japanese translation of docs/feature_led_matrix.md (qmk#8991)
  [Docs] Japanese translation of docs/feature_layouts.md (qmk#8949)
  [Docs] Japanese translation of docs/feature_thermal_printer.md (qmk#9034)
  [Docs] Japanese translation of docs/feature_velocikey.md (qmk#9035)
  [Docs] Japanese translation of docs/feature_leader_key.md (qmk#8950)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants