V-USB: Remove some stuff from usbconfig.h that should not be configurable #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Apr 2, 2020
zvecr
approved these changes
Apr 3, 2020
zvecr
approved these changes
Apr 4, 2020
drashna
approved these changes
Apr 5, 2020
zvecr
changed the title
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
Apr 12, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
thorstenweber83
pushed a commit
to thorstenweber83/qmk_firmware
that referenced
this pull request
Sep 2, 2020
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…able (qmk#8656) * V-USB: Remove some stuff from usbconfig.h that should not be configurable * Clean up some ifdefs * And some more * Even more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able
Description
As with the LUFA/ChibiOS descriptors, the device/interface class/subclass/protocol does not need to be configurable, so we can safely hardcode it in the descriptors. V-USB is also aware of
F_CPUand soUSB_CFG_CLOCK_KHZis not necessary either.Types of Changes
Issues Fixed or Closed by This PR
Checklist