Trim firmware sizes from default rules.mk, part 2 #8040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
reviewed
Jan 30, 2020
fauxpark
approved these changes
Jan 30, 2020
|
Thanks for catching that @noroadsleft, I resolved the conflict with |
zvecr
approved these changes
Jan 30, 2020
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to remove all firmware filesize changes from all board-level and default keymap
rules.mkfiles. This first round is only keyboards starting with 'g' - 'm'.The idea here is to reduce blindly copy-pasting outmoded conventions into new firmware submissions (and, by extension, prevents QMK collaborators from having to request such amendments going forward).
Types of Changes
Removed parenthetical reference to firmware filesize changes in
rules.mkat the keyboard and default keymap level for any boards/vendors starting with[g-m].I was a little more thorough with getting more default-ish type boards (revs, different layouts) but specifically avoided the
hardwiredirectory for now.Checklist