Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Space Cadet keycodes to their own section in keycode reference #7889

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Move Space Cadet keycodes to their own section in keycode reference #7889

merged 1 commit into from
Jan 14, 2020

Conversation

fauxpark
Copy link
Member

Description

Also removed documentation of F(), M(), and MACROTAP() to avoid confusion, and encourage users towards process_record_user().

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 14, 2020 01:31
@drashna drashna requested a review from a team January 14, 2020 01:37
@zvecr zvecr merged commit c7b2d60 into qmk:master Jan 14, 2020
@fauxpark fauxpark deleted the space-cadet-keycode-docs branch January 14, 2020 21:25
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @HokieGeek
Move Space Cadet keycodes to their own section in keycode reference (q…
55b2593 
…mk#7889)
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @kujawakk
Move Space Cadet keycodes to their own section in keycode reference (q…
babe85d 
…mk#7889)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @zvecr
Move Space Cadet keycodes to their own section in keycode reference (q…
6d491ad 
…mk#7889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr