Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yurei PCB #7880

Merged
merged 16 commits into from
Jan 14, 2020
Merged

Add Yurei PCB #7880

merged 16 commits into from
Jan 14, 2020

Conversation

kkatano
Copy link
Contributor

@kkatano kkatano commented Jan 13, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Jan 13, 2020
View reviewed changes
keyboards/yurei/config.h Outdated Show resolved Hide resolved
keyboards/yurei/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/yurei/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yurei/rules.mk Outdated Show resolved Hide resolved
keyboards/yurei/yurei.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team January 13, 2020 12:39
@kkatano kkatano requested review from fauxpark and removed request for a team January 13, 2020 12:55
fauxpark
fauxpark requested changes Jan 13, 2020
View reviewed changes
keyboards/yurei/yurei.h Outdated Show resolved Hide resolved
keyboards/yurei/rules.mk Show resolved Hide resolved
keyboards/yurei/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yurei/info.json Outdated Show resolved Hide resolved
kkatano and others added 4 commits January 13, 2020 22:37
@kkatano @fauxpark
Update keyboards/yurei/yurei.h
828328f 
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@kkatano @fauxpark
Update keyboards/yurei/keymaps/default/keymap.c
dcd5205 
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@kkatano @fauxpark
Update keyboards/yurei/info.json
62c4c1c 
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@kkatano @fauxpark
Update keyboards/yurei/rules.mk
7338e34 
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@fauxpark fauxpark requested a review from a team January 13, 2020 13:44
@drashna drashna requested a review from noroadsleft January 13, 2020 18:02
noroadsleft
noroadsleft approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@noroadsleft noroadsleft merged commit c58f785 into qmk:master Jan 14, 2020
@noroadsleft
Copy link
Member

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

To resynchronize your master branch, follow the instructions here:

Resynchronizing a Branch

If you need any help with either of these tasks, just ask.

Thanks for your contribution!

@kkatano
Copy link
Contributor Author

kkatano commented Jan 14, 2020

Thanks for the review. I will read the page you indicated.

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@kkatano @HokieGeek
[Keyboard] Add Yurei PCB (qmk#7880)
dc06030 
* Add yurei

* Implement keyboard

* Update readme.md

* Update config.h

* Update info.json

* Update info.json

* Update keyboards/yurei/config.h

* Delete config.h

* Update rules.mk

* Update yurei.c

* Update keymap.c

* Update keyboards/yurei/yurei.h

* Update keyboards/yurei/keymaps/default/keymap.c

* Update keyboards/yurei/info.json

* Update keyboards/yurei/rules.mk
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@kkatano @kujawakk
[Keyboard] Add Yurei PCB (qmk#7880)
0859034 
* Add yurei

* Implement keyboard

* Update readme.md

* Update config.h

* Update info.json

* Update info.json

* Update keyboards/yurei/config.h

* Delete config.h

* Update rules.mk

* Update yurei.c

* Update keymap.c

* Update keyboards/yurei/yurei.h

* Update keyboards/yurei/keymaps/default/keymap.c

* Update keyboards/yurei/info.json

* Update keyboards/yurei/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkatano @noroadsleft @drashna @fauxpark